Skip to content

Commit

Permalink
Deprecate flask-webservice related functionality
Browse files Browse the repository at this point in the history
- affects modules: httprequests, fflask, resources
- probably in version v0.24.0.0
- related to #53
  • Loading branch information
pylipp committed Dec 30, 2019
1 parent a37cacd commit 7857f9c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- The versioning scheme now adheres to '0.major.minor.patch' to correctly indicate impacts of new releases. (#54)
- The 'communication' module is renamed to 'clients'.
### Deprecated
- Flask-webservice related functionality will be moved to a dedicated plugin. (#53)
### Removed
- communication.module() and httprequests/localserver.proxy() functions.
### Fixed
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ The user request invoked from the CLI is passed to the backend which opens the a

### Client-server mode

> Flask-webservice related functionality will be moved to a dedicated plugin, see #53.
To run `financeager` as client-server application, start the flask webservice by

export FLASK_APP=financeager/fflask.py
Expand Down
7 changes: 7 additions & 0 deletions financeager/clients.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
from . import httprequests, localserver, offline, plugin
from .exceptions import InvalidRequest, CommunicationError, OfflineRecoveryError

logger = financeager.init_logger(__name__)


def create(*, configuration, sinks, plugins):
"""Factory to create the Client subclass suitable to the given
Expand Down Expand Up @@ -88,6 +90,11 @@ def __init__(self, *, configuration, sinks):

financeager.init_logger("urllib3")

logger.warning(
"Flask-webservice related functionality will be moved to a "
"dedicated plugin.\n"
"Check the Changelog when updating your financeager version.")

def safely_run(self, command, **params):
"""Execute base functionality.
If successful, attempt to recover offline backup. Otherwise store
Expand Down

0 comments on commit 7857f9c

Please sign in to comment.