Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python-build): Add PACKAGE_LDFLAGS to support custom LDFLAGS per package #2927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cfxegbert
Copy link

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR
    Adds PACKAGE_LDFLAGS to be able to pass LDFLAGS separately to readline and python

Tests

  • My PR adds the following unit tests (if any)

Copy link
Member

@native-api native-api left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I was sure this was already available.

Could you adjust the tests, too? We can probably test this in the same test that tests PACKAGE_CFLAGS.

@native-api
Copy link
Member

native-api commented Mar 19, 2024

We can probably test this in the same test that tests PACKAGE_CFLAGS.

...And my memory fails me here, too: there is no such test.
There is however "yaml is installed for python" in build.bats which simulates a build of a dependency package and shows its build flags -- this can be taken as a base.


It's also worth documenting the new envvar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PACKAGE_LDFLAGS to python-build
2 participants