Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish shell config docs #2786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BooleanCat
Copy link

@BooleanCat BooleanCat commented Sep 14, 2023

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Copying the instructions for configuring the fish shell for pyenv verbatim fails because fish_add_path fails when the target directory doesn't exist.

Tests

  • My PR adds the following unit tests (if any)

N/A - doc change only.

Copy link
Member

@native-api native-api left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pointless to create $PYENV_ROOT/bin if it doesn't exist.
The command should then be conditional on the directory existing.

Same goes for the 2nd snippet just below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants