Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --bare option to pyenv version #2783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjwatt
Copy link

@jjwatt jjwatt commented Sep 8, 2023

It just points at pyenv version-name. This adds consistency with the behavior of pyenv versions --bare

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.

I don't use rbenv, but from a quick look, I could make a similar change there. However, the files in question are already different (though the behavior is similar).

Description

  • Here are some details about my PR
    Adds a --bare flag to pyenv version

Tests

  • My PR adds the following unit tests (if any)

It just points at pyenv version-name.  This adds consistency with the behavior
of `pyenv versions --bare`
@native-api
Copy link
Member

Please add a test for the new option.

@jjwatt
Copy link
Author

jjwatt commented Sep 11, 2023

Sure thing! bats for testing. Excellent. I think I see just where to add it.

@anton-petrov
Copy link
Member

@jjwatt Hi, so what about tests? I think, PR is ready for merge, except of tests.

@anton-petrov anton-petrov added awaiting response more information requested need-feedback labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response more information requested need-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version has no --bare option, but versions has a --bare option
3 participants