Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(馃悶) use exec mode by default #101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(馃悶) use exec mode by default #101

wants to merge 2 commits into from

Conversation

KotlinIsland
Copy link

@KotlinIsland KotlinIsland commented Mar 22, 2023 •
edited

@KotlinIsland KotlinIsland changed the title (馃悶) use exec mode when passed a list of strings (馃悶) use exec mode by default Mar 23, 2023
thearchitector
thearchitector reviewed Jul 22, 2023
View reviewed changes
src/subprocess_tee/__init__.py
stderr=asyncio.subprocess.PIPE,
**platform_settings,
)
if isinstance(args, str):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a potentially wiser check might be to replicate what subprocess does, as in force people to be explicit about using "shell mode":

If passing a single string, either shell must be [True](https://docs.python.org/3/library/constants.html#True) (see below) or else the string must simply name the program to be executed without specifying any arguments.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, i did not know you could review PRs on repos you can't write to

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, need to remove lines 141-147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thearchitector thearchitector thearchitector left review comments

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Execution is always as a shell
2 participants
@KotlinIsland @thearchitector