Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue.remove_field_value() #1834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickbroon
Copy link

Complements the existing add_field_value()

@adehad
Copy link
Collaborator

adehad commented Mar 25, 2024

@nickbroon thanks for this! Do you think we can add a test (to: tests\resources\test_issue.py) where perhaps we

  1. add the value (perhaps to the label field)
  2. check the value is added
  3. remove the value
  4. check the value is removed
    ?

@nickbroon nickbroon force-pushed the nickbroon-remove_field_value branch from 550daa1 to 3046ac5 Compare May 2, 2024 10:55
@nickbroon
Copy link
Author

nickbroon commented May 2, 2024

thanks for this! Do you think we can add a test (to: tests\resources\test_issue.py) where perhaps we

  1. add the value (perhaps to the label field)
  2. check the value is added
  3. remove the value
  4. check the value is removed
    ?

adehad, I pushed a update to the Pull Request that adds a test that exercises both remove_field_value() and add_field_value()

Complements the existing add_field_value()
@nickbroon nickbroon force-pushed the nickbroon-remove_field_value branch from 7669ec4 to b57c08d Compare May 2, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants