-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/joint diarization and embedding with prepared data #1583
Draft
clement-pages
wants to merge
90
commits into
pyannote:develop
Choose a base branch
from
clement-pages:feat/joint-diarization-and-embedding-with-prepared-data
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/joint diarization and embedding with prepared data #1583
clement-pages
wants to merge
90
commits into
pyannote:develop
from
clement-pages:feat/joint-diarization-and-embedding-with-prepared-data
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING(model): get rid of (flaky) `Model.introspection`
…o feat/joint-diarization-and-embedding
- fixes the dimension error between files id and probabilties arrays - changes the way of how chunks for the embedding task are sampled - creates two functions to draw chunks, one for each subtask Tests are required to ensure that there are no bugs
For now this is a copy past from methods in segmentation task.
as computing this loss probably does not make sense in powerset mode because first class (empty set of labels) does exactly this
as this instance attribute was not used
…` pipeline Co-authored-by: Hervé BREDIN <[email protected]>
as these loop could break gradient flow and to optimize the code
for now do the trick only for the diarization subtask
* use npz archive instead pickle to save task data * improve code readability * improve(task): update numpy array dtypes In order to use types whose size better machtes the contents of the arrays * remove `end` entry from `annotated_regions` numpy array This entry was redundant with the start and duration entries, since `end` = `start` + `duration`. * fix: allow data preparation to be finished when task has no validation * improve: clear data lists after assignation to `self.prepared_data` This is to avoid data redundancy in the `prepare_data` method --------- Co-authored-by: clement-pages <[email protected]>
Now the joint task uses `prepare_data` and `setup` from core `Task` and `SpeakerDiarization` task.
…' of github.com:clement-pages/pyannote-audio into feat/joint-diarization-and-embedding-with-prepared-data
…embedding-with-prepared-data
…ddins This new model is based on a `WeSpeakerResnet34` for the speaker embeddings extraction part, and on `PyanNet` for (local) segmentation.
…embedding-with-prepared-data
…embedding-with-prepared-data
Now, the first `num_dia_samples` samples in a batch are dedicated to the diarization substak, and the remaining sample are for the embedding subtask
... and fix some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.