fixes #511 -- Support Exposing JVM Debug Port #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehigham
commented
Mar 8, 2023
| @@ -1075,6 +1075,14 @@ def testJavaopts(self): | |||
| self.gateway = JavaGateway.launch_gateway(javaopts=["-Xmx64m"]) | |||
| self.assertTrue(self.gateway.jvm) | |||
|
|
|||
| def testJvmDebugPort(self): | |||
| from random import randint | |||
| dport = randint(5000, 5999) | |||
There was a problem hiding this comment.
Using a random int in case tests are run in parallel and we run into port conflicts. I don't think the actual number matters.
ehigham
commented
Mar 8, 2023
Comment on lines
+339
to
+343
| try: | ||
| _port = int(proc.stdout.readline()) | ||
| except ValueError: | ||
| # If a JVM debug port is exposed, its details will be printed first | ||
| pass |
There was a problem hiding this comment.
Not sure if there's a better way of doing this other than consuming just enough stdout to successfully parse the int.
|
Sorry for the delay. Now the tests are fixed per #519. Would you mind rebasing this one please? |
When users expose JVM debug ports, the JVM prints information about the debug port on initialization (ie before `main` is invoked). Discard stdout noise until the port is successfully read.
ehigham
force-pushed
the
issue-511-jvm-debug-port
branch
from
fe8cf02
to
5537da2
Compare
No worries! Thanks for taking a look. Rebase pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users expose JVM debug ports, the JVM prints information about the debug port on initialization (ie before
mainis invoked). Discard stdout noise until the port is successfully read.