Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root logger used in send command #499

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Root logger used in send command #499

wants to merge 3 commits into from

Conversation

Baunsgaard
Copy link

This PR fixes the logger used in exception handling when sending commands.
Previously the root logger was used, and with this fix the py4j specific logger is used.

@Baunsgaard
Root logger used in send command
1069220 
This PR fixes the logger used in exception handling when sending commands.
Previously the root logger was used, and with this fix the py4j specific logger is used.
HyukjinKwon
HyukjinKwon approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a cursory look. cc @ueshin FYI

@Baunsgaard
Copy link
Author

@HyukjinKwon
I ran into this issue again in my code base.
and now the new merge conflict is resolved as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Baunsgaard @HyukjinKwon