Give py4j threads explicit names, mark them as daemon #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
changed the title
|
I didn't go as far as allowing py4j users to provide their own |
|
oh yeah, probably it's a good idea to name them |
HyukjinKwon
reviewed
Aug 25, 2022
| @@ -0,0 +1,31 @@ | |||
| package py4j; | |||
There was a problem hiding this comment.
I think you don't have to bother with creating a util here. Let's just fix them inplace at GatewayServer, ClientServerConnection, and let's name them.
HyukjinKwon
reviewed
Aug 25, 2022
| int index = counter.incrementAndGet(); | ||
| String name = "py4j-" + index; | ||
| Thread thread = new Thread(r, name); | ||
| thread.setDaemon(true); |
There was a problem hiding this comment.
but why should we make it a daemon though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes py4j give more explicit names to the threads it creates (like
py4j-…rather than the defaultThread-…), which makes it easier to inspect JVM processes where py4j is running.It also marks those threads as daemon, so that exiting the main thread of the JVM, by reaching the end of the
mainmethod, actually makes the JVM exit (provided no other non-daemon threads were created by users).