docs: Add note about giving credit to ported tools #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for being mindful of the license. Regarding credit, I don't like the practice of doing it in source code. Maybe we have a separate file for this type of credit, could even be on the website for more visibility. |
|
Ya a separate file makes sense, especially since many tools will be broken across many files in the end so hard to say what one to put the comment in. Any ideas on what the file should be? CREDITS.md? |
fidgetingbits
force-pushed
the
developing-docs
branch
from
66f2074
to
764f850
Compare
|
Updated to suggest using |
|
CREDITS.md works for me. We can change it if anyone has better suggestion |
gsingh93
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord, suggest people give proper credit to ported tools. This includes some minor auto linting from my editor, which I can remove if it matters.