Create config options from choices #2090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2090 +/- ##
=======================================
Coverage 59.68% 59.69%
=======================================
Files 191 191
Lines 24418 24435 +17
Branches 2419 2423 +4
=======================================
+ Hits 14574 14586 +12
- Misses 9061 9064 +3
- Partials 783 785 +2 ☔ View full report in Codecov by Sentry. |
| # validate param value before trigger | ||
| if not config.validate_choices(self.param.name, self.param.value): | ||
| self.param.revert_default() | ||
| return f"Invalid value '{self.param.value}' for parameter '{self.param.name}'. Valid choices are: {', '.join(self.param.choices)}" |
There was a problem hiding this comment.
Does this if need to be in the trigger loop? The condition do not use trigger at all and here we will be re-validating things on each trigger. Is that needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414 by adding a way to validate config options from choices.
Need to figure out where else this might be needed (or not) and also edit tests.