Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where gdb.execute during object loading causes an exception. #1755

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SamiKalliomaki
Copy link

Please note I have roughly no idea what I am doing and all of this code may be stupid. However, it solves the issue for me.

#1754

@gsingh93
Copy link
Member

Thanks for the contribution! Would you be able to add a test case for this issue first so we can better understand the problem and your solution, and make sure this doesn't regress in the future? See https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md#testing

@SamiKalliomaki
Copy link
Author

Considering this makes a lot tests fail - I suspect this will not be able to merged in the current iteration. I think the issue is that I don't really understand the issue myself that well either.

What I have found is that running gdb.execute from this event handler seems to crash. I would guess this is because there is probably another command already in progress. But this might be a GDB bug as well (assuming the issue is not reproducible for everyone).

So right now I'd be looking for feedback on the approach and then we could see if there is a reproducible test that can be implemented.

@codecov-commenter
Copy link

Codecov Report

Merging #1755 (2182b71) into dev (1d635f0) will decrease coverage by 56.47%.
The diff coverage is 40.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev   #1755       +/-   ##
==========================================
- Coverage   60.63%   4.17%   -56.47%     
==========================================
  Files         175     175               
  Lines       21300   21308        +8     
  Branches     1909    1909               
==========================================
- Hits        12915     889    -12026     
- Misses       7745   20298    +12553     
+ Partials      640     121      -519     
Impacted Files Coverage Δ
pwndbg/gdblib/arch.py 30.00% <0.00%> (-43.34%) ⬇️
pwndbg/gdblib/events.py 12.58% <42.85%> (-67.84%) ⬇️

... and 162 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants