Refactor telescope, hexdump, and enhance to use ColorConfig #1324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@disconnect3d there are a few config options that didn't properly follow the naming convention between the parameter name and the function name. I've made these consistent:
Also,
hexdump-highlight-group-lsb
was essentially a color parameter but was not named like one. The name sounds like it's a boolean, but you can customize how you want the lsb to be colored (the default is "underline"), so I renamed it tohexdump-lsb-color
.With these renamings, how do we not break existing themes? I'd like to display a message if anyone is explicitly setting a deprecated paramater.
Maybe something like
DeprecatedParameter('hexdump-highlight-group-lsb', 'hexdump-lsb-color')
, which would detect when someone tries to access the old name for the first time, print a deprecation warning, and then re-map it to the correct config name. Then we can remove the old config in the future.