Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

skipping node if some pods on that node do not have enough pdbs #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deepak1100
Copy link

PR for below issue
#54

@pusher-ci
Copy link

Hi @Deepak1100. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Deepak1100 Deepak1100 changed the title CLOUD-2798 | Deepak Jain| skipping node if some pods on that node do not have enough pdbs skipping node if some pods on that node do not have enough pdbs Jul 31, 2019
@@ -57,7 +57,7 @@ var (
`Optional, if this controller is running in a kubernetes cluster, use the
pod secrets for creating a Kubernetes client.`)

namespace = flags.String("namespace", "kube-system",
namespace = flags.String("rescheduler-namespace", "kube-system",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been done to make rescheduler run locally. as kube default config also set the namespace and we will get error

panic: rescheduler: rescheduler flag redefined: namespace

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants