Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🧑‍💻 Upload dist/pros/* #340

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

meisZWFLZ
Copy link

Summary:

Upload dist/pros/* instead of dist/*, which removes the extra pros directory:

.
└── pros
    ├── _internal
    ├── intercept-c++.exe
    ├── intercept-cc.exe
    └── pros.exe

->

.
├── _internal
├── intercept-c++.exe
├── intercept-cc.exe
└── pros.exe

Motivation:

Uploading the extra pros directory adds another potential point of failure when creating releases that can be easily mitigated by removing it.

References (optional):

Test Plan:

  • the artifacts here no longer have an extra pros directory

Additional Notes

  • It does remove the python wheel thing from the ubuntu artifact, so I hope that's not necessary

Squash merge please

dont want those test commits clogging up the commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant