✨ Setup initial unit tests for conductor #329
Open
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Spec in pros/conductor/conductor.py:194 and pros/conductor/templates/base_template.py:33
ayushuk
changed the title
…lass, replaced '==' with '>=' in the unit test
I think this could be due to a version difference for the okapilib template. It is unrealistic to have the unit test try for an exact version number over time, so I added a greater than or equal to method in the BaseTemplate class (ge). The unit test now uses this to compare templates, this should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a very simple unit test for the resolve_template method in the Conductor class using the unittest Python library
Motivation:
Intending to add more complex unit tests for various methods/classes across the repo in the future, starting with something simple for the Conductor class
References (optional):
Test Plan: