Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount a tmpfs on /run, like other distros do #3940

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

dimkr
Copy link
Contributor

@dimkr dimkr commented Feb 24, 2023

Previously denied in #2080, because at least one package seems to be buggy: it stores files in /run and expects them to persist. That's not why /run exists, it's supposed to store runtime state and not state in general. When it's persistent, it pollutes save files, slows down save2flash and causes extra writing.

@dimkr dimkr marked this pull request as ready for review April 21, 2023 11:59
@gyrog
Copy link
Contributor

gyrog commented Nov 29, 2023

Obvious question, what has changed since #2080?

I'm not familiar with other Linux distributions, but it seems reasonable that /run should not be expected to persist.

Maybe there needs to be a dicussion about which files are considered as appropriate to be persistent.
I'm not sure how to bring such a discussion to the attention of significant numbers of Puppy users.

One of the advantages of the "indirect" save mechanisms like pupmode=13, is that it provides an oportunity to screen out the "rubbish" from being written to the "save".
It would be nice to have an agreed list, so all save mechanisms could be consisent.
Could even do a "cleanup" process for pupmode=12 in init, based on the list.

@dimkr
Copy link
Contributor Author

dimkr commented Nov 29, 2023

Obvious question, what has changed since #2080?

Time

Maybe there needs to be a dicussion about which files are considered as appropriate to be persistent.

I don't see any room for discussion, /run is supposed to be non-persistent and anything that stores stuff there and expects it to persist should be fixed, not the other way around. Somebody, I don't know who, when or why, built a popular .pet or .sfs that puts stores persistent stuff in /run, and that's why Puppy is pretty much the only distro to write /run to disk (only under PUPMODE 12, but still a bad idea).

@gyrog
Copy link
Contributor

gyrog commented Nov 30, 2023

So, the code that expects persistence for files in /run, could still be out there.
This may cause "complaints" that stuff is getting lost.

That's why it would be good to have a discussion about what directories should be kept, and which can be ignored, (not just about /run) . So that the Puppy community in general will not produce code that breaks the agreed lists.

But I do agree that the offending code needs to be fixed.
The difficulty is in identifying it.
Of course implementing this would be one way of finding it.
Unfortunately the user who would get stung, is probably not the person who is responsible for the problem.

@dimkr
Copy link
Contributor Author

dimkr commented Nov 30, 2023

The difficulty is in identifying it.

The easiest way to identify it is to align Puppy with all other distros by making /run a tmpfs, and wait 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants