Start exporting Java SDK #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on starting to deploy java SDK during pre-release, but using https://github.com/pulumi/pulumi-package-publisher/tree/main to reduce duplication. There are a couple open questions: * I was getting complaints about the tree not being clean when building the java version. Not sure why it is different than the other builds. * Tests are not enabled for java, since I believe it requires writing some test like for the other languages. Can take a look, but have not yet. Other notes: * I've delete master.yml, since it seems unused, and is one less place to copy similar logic. * I've updated prelease.yml and release.yml, but not much on main.yml, since it surprised me it did publishing of sdks. Open to discussion on what should be in it.
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
This is meant to address #7. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
No problems found on commit 8ad69dd
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with 鉂わ笍 by ellipsis.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on starting to deploy java SDK during pre-release, but using https://github.com/pulumi/pulumi-package-publisher/tree/main to reduce duplication.
There are a couple open questions:
Other notes:
Testing:
Please let me know your thoughts. Thanks!
Summary:
This PR initiates the export of the Java SDK during pre-release, deletes an unused file, and updates two workflow files, but notes that tests for Java are not enabled and several secrets are needed.
Key points:
pulumi-package-publishermaster.ymlfileprerelease.ymlandrelease.ymlGenerated with 鉂わ笍 by ellipsis.dev