Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a-schot/pulumi-dbtcloud to community package list #3898

Closed
wants to merge 1 commit into from

Conversation

a-schot
Copy link

@a-schot a-schot commented Feb 3, 2024

Description

Added a bridged provider for dbt Cloud.

  • The logo which can be used for the Pulumi Registry can be found here, couldn't find where to submit this, however.
  • Any tips on how to exclude the legacy dbt_cloud-prefixed resources would be much appreciated. I had to map them all to Legacy<resourcename>, otherwise the binary would panic.

Adding a new package?

If this pull request adds a new package:

  • The package's schema URL is correct.
  • The package metadata file, if present, contains:
    • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • a description that explains what the package does.
    • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
    • a version number prefixed with v that corresponds with a valid GitHub release.
  • The package repo contains an Overview doc (/docs/_index.md) that includes:
    • a brief explanation of what the package is and what it does.
    • at least one representative example in all supported languages.
    • a front-matter property for the layout set to package.
  • The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • links to SDKs in all supported languages.
    • a copyable command for installing the resource plugin if necessary.
    • an example of configuring the provider with pulumi config set.
    • an example of configuring the provider with environment variables.
  • A CODEOWNER has reviewed the PR.
  • Someone from the @pulumi/docs team has reviewed all documentation.

@ringods ringods requested review from ringods and removed request for AaronFriel March 13, 2024 08:36
Copy link
Member

@ringods ringods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-schot Please integrate the following changes in your provider repository:

Logo

Commit the icon to your repo, and set the LogoURL in provider/resource.go like this:

https://github.com/ctfer-io/pulumi-ctfd/blob/main/provider/resources.go#L35

Plugin Download URL

Preferrably use the explicit support for Github Releases as the PluginDownloadURL. Example:

https://github.com/ctfer-io/pulumi-ctfd/blob/main/provider/resources.go#L32

Command to download the plugin

Please add a section to docs/installation-configuration.md documenting how to download the plugin binary. Use the special Github URL from previous section as the value for the --server argument. Example:

https://github.com/ctfer-io/pulumi-ctfd/blob/main/docs/installation-configuration.md?plain=1#L16-L24

Legacy resources

In the meantime, I will check with our engineering team how to hide the legacy resources/datasources.

@a-schot
Copy link
Author

a-schot commented Apr 3, 2024

@ringods Thanks for the feedback!

I implemented the three points mentioned in your reply and ticked the boxes in the original PR text to reflect that.

@ringods
Copy link
Member

ringods commented Apr 3, 2024

@a-schot I noticed an incorrect value for your download URL.

a-schot/pulumi-dbtcloud@2330d98#r140550943

After fixing the download URL, can you create a new release of your package containing all these changes?

@a-schot
Copy link
Author

a-schot commented Apr 3, 2024

@ringods Good catch.

I fixed it and released a new version: https://github.com/a-schot/pulumi-dbtcloud/actions/runs/8540656535

@iwahbe
Copy link
Member

iwahbe commented Apr 3, 2024

Hey @a-schot. I'm sorry to hear that about those extra legacy mappings. You shouldn't need to do that. Can you post a copy of the panic stack trace to pulumi/pulumi-terraform-bridge#1838. We would like to fix this for you.

@ringods
Copy link
Member

ringods commented Apr 3, 2024

@a-schot to ignore some of the legacy TF resources and not expose these in the Pulumi version, you should be able to use the IgnoreMappings property within provider/resources.go:

https://github.com/pulumi/pulumi-terraform-bridge/blob/9257734f4e75379fc05f0d99dd19b461111b44b1/pkg/tfbridge/info.go#L86

@a-schot
Copy link
Author

a-schot commented Apr 3, 2024

@ringods It doesn't seem like that is happening right now. I am using that property currently for all dbt_cloud_ prefixed resources/datasources. This does prevent the errors thrown by tfgen but the binary will still panic at runtime (see my comment on pulumi/pulumi-terraform-bridge/issues/1838)

@ringods
Copy link
Member

ringods commented Apr 11, 2024

@a-schot can you update the pulumi TF bridge in your provider to this release and retry?

https://github.com/pulumi/pulumi-terraform-bridge/releases/tag/v3.80.0

It includes this fix:

Do not map resources/datasources specified in IgnoreMappings

@ringods
Copy link
Member

ringods commented Apr 30, 2024

@a-schot checking in again as we haven't heard from you in a few weeks. Would you have time to checkout this PR I created?

a-schot/pulumi-dbtcloud#1

I upgraded the bridge and removed the legacy mappings.

@mikhailshilkov
Copy link
Member

Closing in favor of the first-party package available in https://www.pulumi.com/registry/packages/dbtcloud/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants