Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use test environments for codegen tests #15884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Apr 10, 2024

  1. use test environments for codegen tests

    Currently these tests always just use the directory in the repository
    tree to run.  This isn't great for a couple of reasons:
    - The tests write files into the repo tree (these are .gitignored, but
      still large and aren't cleaned up after the test finished)
    - Tests running in parallel can potentially use the same directory.
    
    We have a nice helper that creates new test environments and cleans
    them up at the end of the tests.  Use that here for more test
    isolation.
    
    Also remove the t.Run() in the inner loop.  For a lot of these tests
    it's not possible to run only one bit at a time (which is also why
    there is an ordering enforced).  It's better to just make them run in
    the outer test loop to avoid confusion when trying to rerun only part
    of the test.
    tgummerer committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3b0b261 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Configuration menu
    Copy the full SHA
    7f3cf2a View commit details
    Browse the repository at this point in the history