Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Package Schema resource-typed properties #15795

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Package Schema resource-typed properties #15795

wants to merge 6 commits into from
+5,940 −144

Commits on May 14, 2024

  1. feat: Package Schema resource-typed properties 

    A new built-in type, `pulumi.json#/Resource` is added to the schema to refer to
any resource. This unblocks schematizing resources like
`kubernetes.yaml/v2.ConfigFile`, which ideally would declare an output like so:

```json
            "properties": {
                "resources": {
                    "type": "array",
                    "items": {
                        "$ref": "pulumi.json#/Resource"
                    },
                    "description": "Resources created by the ConfigFile."
                }
            },
```

This is a small ergonomic improvement over `pulumi.json#/Any`, and fixes #6346.
    @AaronFriel @EronWright
    AaronFriel authored and EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5267dcc View commit details
    Browse the repository at this point in the history

  2. Add support for ResourceMapOutput, et al. 

    This moves more of the Resource type's implementation to the generated
`types_builins.go`.
    @AaronFriel @EronWright
    AaronFriel authored and EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1ddd43d View commit details
    Browse the repository at this point in the history

  3. fix: Enable Go SDK to unmarshal into compatible interfaces 

    This PR unblocks the integration test below, which modified the Echo provider
to pass-through its inputs to outputs - including resources.

There remains a bug in re-marshaling a resource inside a provider that we avoid
by simplifying `Create()` to pass-through. This is or is related to #15788.
    @AaronFriel @EronWright
    AaronFriel authored and EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aa2bdab View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Eron Wright <[email protected]>
    @AaronFriel @EronWright
    AaronFriel and EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f8e819f View commit details
    Browse the repository at this point in the history

  5. Go mod tidy

    @AaronFriel @EronWright
    AaronFriel authored and EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9d4d4e2 View commit details
    Browse the repository at this point in the history

  6. feedback

    @EronWright
    EronWright committed May 14, 2024
    Configuration menu
    Copy the full SHA
    51cb486 View commit details
    Browse the repository at this point in the history