Apply suggestions from code review

Co-authored-by: Eron Wright <[email protected]>
pulumi · Apr 9, 2024 · b0aa1ba · b0aa1ba
1 parent 8cd0a87
commit b0aa1ba
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/pkg/codegen/schema/schema.go b/pkg/codegen/schema/schema.go
@@ -72,7 +72,7 @@ func (t primitiveType) String() string {
  case jsonType:
  fallthrough
  case anyResourceType:
- fallthrough
+ return "pulumi:pulumi:Resource"
  case anyType:
  return "pulumi:pulumi:Any"
  default:

diff --git a/sdk/go/pulumi/rpc.go b/sdk/go/pulumi/rpc.go
@@ -921,7 +921,6 @@ func unmarshalOutput(ctx *Context, v resource.PropertyValue, dest reflect.Value)
  return secret, nil
  }
 
- // TODO: pulumi.Resource is a non-empty interface type
  if !anyType.Implements(typ) {
  return false, fmt.Errorf("cannot unmarshal into non-empty interface type %v", dest.Type())
  }

diff --git a/tests/integration/any_resource_types/go/echo_resource.go b/tests/integration/any_resource_types/go/echo_resource.go
@@ -2,7 +2,7 @@
 //go:build !all
 // +build !all
 
-// Exposes the FailsOnDelete resource from the testprovider.
+// Exposes the Echo resource from the testprovider.
 
 package main
 

diff --git a/tests/integration/any_resource_types/go_test.go b/tests/integration/any_resource_types/go_test.go
@@ -11,7 +11,7 @@ import (
  "github.com/stretchr/testify/assert"
 )
 
-// TestDeletedWithGo tests the DeletedWith resource option.
+// TestAnyResource tests the `pulumi.json/#Resource` schema type.
 //
 //nolint:paralleltest // ProgramTest calls t.Parallel()
 func TestAnyResource(t *testing.T) {