Fixes from review comments

pulumi · Apr 12, 2024 · 6ca6016 · 6ca6016
1 parent 8ca27d4
commit 6ca6016
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/cmd/pulumi/stack_history.go b/pkg/cmd/pulumi/stack_history.go
@@ -163,6 +163,8 @@ func displayUpdatesJSON(updates []backend.UpdateInfo, decrypter config.Decrypter
  info.EndTime = makeStringRef(time.Unix(update.EndTime, 0).UTC().Format(timeFormat))
  resourceChanges := make(map[string]int)
  for k, v := range update.ResourceChanges {
+ // Filter out the the OpOutputChange events because they are psuedo
+ // events that shouldn't be included in the stack history
  if k != deploy.OpOutputChange {
  resourceChanges[string(k)] = v
  }

diff --git a/tests/integration/integration_nodejs_test.go b/tests/integration/integration_nodejs_test.go
@@ -821,9 +821,8 @@ func TestStackReferenceSecretsNodejs(t *testing.T) {
  Quick: true,
  EditDirs: []integration.EditDir{
  {
- Dir: filepath.Join(d, "nodejs", "step2"),
- Additive: true,
- ExpectNoChanges: false,
+ Dir: filepath.Join(d, "nodejs", "step2"),
+ Additive: true,
  ExtraRuntimeValidation: func(t *testing.T, stackInfo integration.RuntimeValidationStackInfo) {
  _, isString := stackInfo.Outputs["refNormal"].(string)
  assert.Truef(t, isString, "referenced non-secret output was not a string")