Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README examples #429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README examples #429

wants to merge 1 commit into from

Conversation

Zaid-Ajaj
Copy link
Contributor

  • bucket: ${my-bucket} -> bucket: ${my-bucket.id} so that pulumi convert works with csharp target from the get-go
  • protect: true to be nested under options

@Zaid-Ajaj Zaid-Ajaj added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 20, 2022
AaronFriel
AaronFriel requested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@AaronFriel AaronFriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather change the YAML to PCL intermediate than the example, as this is an intentional feature of the language.

README.md
@@ -20,7 +20,7 @@ resources:
index.html:
type: aws:s3:BucketObject
properties:
bucket: ${my-bucket}
bucket: ${my-bucket.id}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensuring this behavior works I think is important to the ergonomics of Pulumi YAML.

README.md
Comment on lines +61 to +62
options:
protect: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronFriel AaronFriel AaronFriel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zaid-Ajaj @AaronFriel