fix(html): Produce valid HTML output in Prowler v3 #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3863 +/- ##
==========================================
+ Coverage 85.87% 85.96% +0.08%
==========================================
Files 706 706
Lines 21852 21853 +1
==========================================
+ Hits 18766 18785 +19
+ Misses 3086 3068 -18 ☔ View full report in Codecov by Sentry. |
pedrooot
approved these changes
May 6, 2024
pedrooot
added
backport-v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prowler (v3) failed to produce valid HTML outputs. There were
</div>elementsBrowsers don't seem to mind, but I was experimenting with modifying the generated HTML and ran into issues with XML parsers not accepting the output.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.