chore(docs): update BridgeCrew links in metadata to our local docs link #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check the documentation for this PR here -> SaaS Documentation |
github-actions
bot
added
documentation
provider/aws
|
You can check the documentation for this PR here -> SaaS Documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3858 +/- ##
==========================================
+ Coverage 85.52% 86.40% +0.88%
==========================================
Files 741 746 +5
Lines 22886 23106 +220
==========================================
+ Hits 19573 19965 +392
+ Misses 3313 3141 -172 ☔ View full report in Codecov by Sentry. |
puchy22
suggested changes
Apr 29, 2024
| @@ -249,11 +249,11 @@ Each Prowler check has metadata associated which is stored at the same level of | |||
| # Code holds different methods to remediate the FAIL finding | |||
| "Code": { | |||
| # CLI holds the command in the provider native CLI to remediate it | |||
| "CLI": "https://docs.bridgecrew.io/docs/public_8#cli-command", | |||
| "CLI": "https://docs.prowler.com/checks/public_8#cli-command", | |||
There was a problem hiding this comment.
I think the link you are referring in this file is https://docs.prowler.com/checks/aws/public-policies/public_8/
tests/lib/check/check_loader_test.py
Outdated
| @@ -40,7 +40,7 @@ def get_custom_check_metadata(self): | |||
| Remediation=Remediation( | |||
| Code=Code( | |||
| NativeIaC="", | |||
| Terraform="https://docs.bridgecrew.io/docs/bc_aws_s3_20#terraform", | |||
| Terraform="https://docs.prowler.com/checks/aws/general-policies/bc_aws_s3_20#terraform", | |||
There was a problem hiding this comment.
This link is not correct, please check it
| @@ -46,7 +46,7 @@ def get_custom_check_metadata(self): | |||
| Remediation=Remediation( | |||
| Code=Code( | |||
| NativeIaC="", | |||
| Terraform="https://docs.bridgecrew.io/docs/bc_aws_s3_20#terraform", | |||
| Terraform="https://docs.prowler.com/checks/aws/general-policies/bc_aws_s3_20#terraform", | |||
There was a problem hiding this comment.
This link is not correct, please check it
| @@ -23,7 +23,7 @@ | |||
| Code=Code( | |||
| NativeIaC="", | |||
| Terraform="", | |||
| CLI="https://docs.bridgecrew.io/docs/networking_5#cli-command", | |||
| CLI="https://docs.prowler.com/checks/networking_5#cli-command", | |||
There was a problem hiding this comment.
This file links isn't working, please check it
|
Hi @sergargar, I was checking all the links on metadata were well written. This are my findings of not 200 status code please check it: |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
jfagoagas
approved these changes
Apr 29, 2024
sergargar
added a commit
that referenced
this pull request
May 3, 2024
…nk (#3858) Co-authored-by: puchy22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update BridgeCrew links in metadata to our local docs link.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.