Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mitre azure): add mapping to mitre for azure provider #3857

Merged

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Apr 25, 2024

Context

We need to have Azure checks mapped to MITRE ATT&CK framework as we have for AWS

Description

Azure mitre att&ck mapping for Prowler

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 59.57447% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 86.37%. Comparing base (44ca2f7) to head (bcbed55).
Report is 36 commits behind head on master.

Files Patch % Lines
...ib/outputs/compliance/mitre_attack/mitre_attack.py 8.33% 33 Missing ⚠️
prowler/lib/outputs/file_descriptors.py 25.00% 3 Missing ⚠️
prowler/lib/outputs/compliance/compliance.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
+ Coverage   85.54%   86.37%   +0.83%     
==========================================
  Files         737      748      +11     
  Lines       22780    23295     +515     
==========================================
+ Hits        19487    20121     +634     
+ Misses       3293     3174     -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n4ch04 n4ch04 marked this pull request as ready for review April 26, 2024 10:44
@n4ch04 n4ch04 requested review from a team as code owners April 26, 2024 10:44
snaow
snaow previously requested changes Apr 26, 2024
Copy link
Member

@snaow snaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mittre_attack.py should be mitre_attack.py

@n4ch04
Copy link
Contributor Author

n4ch04 commented Apr 29, 2024

Yep, good catch !

@n4ch04 n4ch04 requested a review from snaow April 29, 2024 05:44
prowler/lib/outputs/compliance/compliance.py Outdated Show resolved Hide resolved
prowler/lib/outputs/compliance/mitre_attack.py Outdated Show resolved Hide resolved
prowler/lib/outputs/compliance/mitre_attack.py Outdated Show resolved Hide resolved
prowler/lib/outputs/compliance/models.py Outdated Show resolved Hide resolved
prowler/lib/outputs/compliance/models.py Outdated Show resolved Hide resolved
@jfagoagas
Copy link
Member

Is there any way to standardise the compliance model for all the providers?

@n4ch04
Copy link
Contributor Author

n4ch04 commented Apr 29, 2024

I tried to do it, but implies changing the field Attributes[{AWSService}] to Attributes[{Service}] to match all the providers which could be a breaking change for some user integrations ...

@n4ch04 n4ch04 requested a review from jfagoagas April 29, 2024 08:25
@jfagoagas jfagoagas added provider/azure Issues/PRs related with the Azure provider and removed testing-pending labels Apr 30, 2024
@n4ch04 n4ch04 requested a review from sergargar April 30, 2024 15:09
prowler/__main__.py Outdated Show resolved Hide resolved
@n4ch04 n4ch04 requested a review from sergargar April 30, 2024 15:10
Co-authored-by: Sergio Garcia <[email protected]>
@n4ch04 n4ch04 requested a review from sergargar April 30, 2024 15:11
@n4ch04 n4ch04 requested a review from sergargar April 30, 2024 15:11
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @n4ch04 !!

@n4ch04 n4ch04 requested a review from sergargar April 30, 2024 15:31
@n4ch04 n4ch04 dismissed snaow’s stale review April 30, 2024 15:33

It is already adressed

@n4ch04 n4ch04 merged commit 722554a into master Apr 30, 2024
10 of 11 checks passed
@n4ch04 n4ch04 deleted the PRWLR-3578-oss-map-azure-checks-to-mitre-att-ck-framework branch April 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants