Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Handle encoding errors #3847

Merged
merged 6 commits into from May 8, 2024
Merged

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Apr 24, 2024

Context

Fixes #3866

Description

Errors related with encoding are solved, new logic for encoding can be found in config.py file from dashboard.

Logic: for windows os, when installing Prowler from pip it is needed to use encoding cp1252 but when using it with python prowler.py dashboard needs to use encoding utf-8

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners April 24, 2024 09:00
@pedrooot pedrooot changed the title feat(d)Handle decoding errors fix(dashboard): Handle encoding errors Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (23df599) to head (d5d8572).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   85.49%   85.51%   +0.01%     
==========================================
  Files         737      737              
  Lines       22779    22780       +1     
==========================================
+ Hits        19476    19481       +5     
+ Misses       3303     3299       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas merged commit c197aa8 into master May 8, 2024
11 checks passed
@jfagoagas jfagoagas deleted the handle-decoding-errors branch May 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge Please, DO NOT MERGE this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Encoding issue with Dashboard on Prowler 4.1.0 - Aces High
2 participants