Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): remove semicolons from metadata texts #3830

Conversation

sergargar
Copy link
Member

Description

Remove semicolons from metadata texts to avoid conflicts with the CSV separator.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Apr 22, 2024
@sergargar sergargar requested review from a team as code owners April 22, 2024 11:16
@github-actions github-actions bot added provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (86cb9f5) to head (f258e0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3830      +/-   ##
==========================================
+ Coverage   86.41%   86.45%   +0.04%     
==========================================
  Files         747      747              
  Lines       23248    23248              
==========================================
+ Hits        20089    20100      +11     
+ Misses       3159     3148      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Apr 22, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed. The ; within double quotes is a valid way to include that character without breaking the CSV output.

@sergargar sergargar removed the no-merge Please, DO NOT MERGE this PR. label Apr 30, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas merged commit 484cf6f into master Apr 30, 2024
11 checks passed
@jfagoagas jfagoagas deleted the 3829-semicolons-used-in-descriptions-break-csv-import-process-remediation-required branch April 30, 2024 12:02
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semicolons used in descriptions break CSV import process - remediation required
2 participants