Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Text.material.toneMapped to false #300

Closed
wants to merge 1 commit into from

Conversation

Methuselah96
Copy link

@Methuselah96 Methuselah96 commented Jan 25, 2024

three.js sets toneMapping to NoToneMapping by default, however react-three-fiber sets it it to ACESFilmicToneMapping by default, which produces some modified colors for Texts.

It would be nice to disable tone mapping by default for Texts since it probably doesn't make sense to apply tone mapping to text.

three.js sets `toneMapping` to `NoToneMapping` by default, however react-three-fiber sets it it to `ACESFilmicToneMapping` by default, which produces some distorted colors.

It would be nice to disable tone mapping by default since it probably doesn't make sense to apply tone mapping to text.
@lojjic
Copy link
Collaborator

lojjic commented May 31, 2024

Hmm, I can see where you're coming from, but to justify changing the default like this (technically a breaking change) I think we'd need to have a very strong rationale. And I'm not so convinced everyone would want to ignore tone mapping on text.

Since R3F is the one defaulting to ACESFilmicToneMapping, perhaps it would make more sense to default to toneMapped:false in Drei <Text> instead?

@Methuselah96
Copy link
Author

Methuselah96 commented May 31, 2024

That's fine, I understand your hesitation. I'm having to override the material in my app anyway, and it doesn't look as straightforward to set this in drei. I spent a little too long trying to figure out what was the difference was, so my motivation was to avoid others running into this as well, but it's arguably more of a problem with fiber/drei than with troika. This was just the easiest place to cover over the difference. Feel free to close.

@lojjic lojjic closed this May 31, 2024
@Methuselah96 Methuselah96 deleted the patch-1 branch May 31, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants