Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env configuration update to ray 1.12 standard #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PhilippWillms
Copy link

This PR goes hand-in-hand with this PR in the JSSEnv repo and contributes to fixing the issue reported in #28. Following the ray 1.12.0 guide on Configuring Environments, a proper ray-compatible env registration is described in main.py. now.

@ingambe ingambe self-requested a review May 8, 2022 21:47
@mf093087
Copy link

mf093087 commented Jan 3, 2023

where is the description in main.py? Could you please help me. Many thanks in advance

@PhilippWillms
Copy link
Author

PhilippWillms commented Jan 3, 2023

where is the description in main.py? Could you please help me. Many thanks in advance

Which description? Comparing the original files with my latest commit I did not find any deleted comment blocks or similar ...

EDIT: Kindly have a look also at the GitHub repository containing the JSSEnv

@mf093087
Copy link

mf093087 commented Jan 3, 2023

where the description in main.py is? Could you please help me. Many thanks in advance

Which description? Comparing the original files with my latest commit I did not find any deleted comment blocks or similar ...

EDIT: Kindly have a look also at the GitHub repository containing the JSSEnv

Thanks a lot for the quick reply! Yes, I have also downloaded this JSSEnv and tried this. However, now I want to try to train the Taillard instance as you did in this repository https://github.com/prosysscience/RL-Job-Shop-Scheduling/tree/master/JSS . When I try run main.py, I receive the following error:
#35

I registered the environment manually, but still, it didn't work..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants