added regexp.MatchString to handle all test cases

[kushalShukla-web]

still need to work on regexp_test.go file . there are doubts that i will clarify with maintainers

[kushalShukla-web]

@ArthurSens can you please review the code and give me any insight :) . like here we should use regexp instead of string.EqualFold right ?

[colega]

Please, add the test case mentioned on the issue to prove that you're actually solving the issue.

[colega]

Even if we forget about performance, I don't think this would work, as k is a literal and regexp.MatchString doesn't do case-insensitive by default.

The strings.EqualFold call would work here, and most likely more performant than a regexp, but what's the point in running a loop of regexp calls here if the entire objective of FastRegexpMatcher is to avoid a single regexp call.

If we can afford that single regexp call, we can just evaluate the original regexp.

[kushalShukla-web]

1. As strings.EqualFold is used for two strings are equal or not in case sensitive way . its not used for checking the regular expression . so i dont think we can use strings.EqualFold here as its only checking for two equal string .
2. also on line 788 we are checking for if !m.caseSensitive { s = strings.ToLower(s) }
   caseSensitive test cases . so if we have some uppercase or upper and lower case test cases then , strings.ToLower(s) will convert them into lowercase right ?

[colega]

its not used for checking the regular expression

equalMultiStringMapMatcher.values does not contain regular expressions, but just the strings.

so if we have some uppercase or upper and lower case test cases then , strings.ToLower(s) will convert them into lowercase right ?

But unicode has more than just uppercase and lowercase. Please, add the test case speicified in the issue and run it with a debugger setting a breakpoint on that condition on line 788 to get a better understanding of the issue.

[kushalShukla-web]

1. Yeah i corrected my self here , actually i thought it contains the regular expression ,but it did't . so basically what im assume here is that the regular expression is some how stored in a simple string formate right .
2. Also do i need to add the test case "ſſs" on the given regexes slice ?
3. Here how did you manage to understand the 1000 lines of code😅 , like apart from this TestFastRegexMatcher_MatchString i really dont understand what other test functions are doing .

[kushalShukla-web]

Hey i think im some how wrong , actually i dont understand that how this function TestFastRegexMatcher_MatchString is related to func (m *equalMultiStringMapMatcher) Matches . i think its some how related to NewFastRegexMatcher .

[colega]

Note that NewFastRegexMatcher analyzes the regular expression and tries to convert it into a set of simplier matchers if it's possible. One of those cases is when the regular expression is just an enumeration of strings, like foo|bar, in which case equalMultiStringMapMatcher is instantiated, with a separate flag to indicate whether the regular expression had the case-insensitive ?i flag.