Persist keep firing for state across restarts #14018
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #13957
In this PR:
Testing:
Apart from unit tests, functionally tested with upto 1000 alerts:
First annotation represents feature being enabled, second annotation is for server restart after which alerts state is restored. Firing alerts are no longer firing when the feature is disabled and server restarts, whereas they keep firing when server restarts and feature is enabled. Minimal spike in eval latency when restoring state.