Always JSON encode, even if not escaping underscores #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into the issue that alerts that e.g. include a line-break cannot be processed anymore after turning off underscore escaping (which in our case, breaks links passed to potential actions that include an underscore). See #270, though I'm not sure if the root cause there is the same.
While debugging, I noticed that when underscores are not escaped, none of the values are JSON encoded at all. This is an ugly but working fix - I don't think it's ideal. As the TODO comment already in the file says, it's probably better to JSON encode the entire card, and then replace underscores (and maybe don't do it for potential actions, as there's no Markdown there).