Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to exclude configmap #250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkindalov
Copy link

In our case we would like to manage the ConfigMap "name: {{ template "app.name" . }}-config" using an external tool. ex Terraform. This is difficult at the moment because both terraform and helm are trying to manage the same resource.

The idea is to make the rendering of this ConfigMap optional.
enableConnectorsConfigMap: [true | false] value was added to the values. The default value ensures that the helm chart will continue to work as before after this change.

About the naming of the value field.
I thought it is better to go with "Enable" instead of "Omit" or "Exclude"

More streamlined approach would be:
connectorsConfigMap:
enabled: true
connectors: []

ref: https://github.com/prometheus-msteams/prometheus-msteams#customise-messages-per-ms-teams-channel

connectorsWithCustomTemplates: []

but that would mean that the chart will lose the backwards compatibility. In my opinion its not worth it :)

If you have any suggestions I am happy to rework the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant