specify namespace for all resources #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows 'helm template' users to specify --namespace 'something' while generating YAML files. See helm/helm#3553 for details and possible (other) workarounds. Note that without specifying --namespace while calling 'helm template', {{ .Release.Namespace }} defaults to 'default' which might contradict what changed in prometheus-msteams#25.
|
Hi @sebhoss, I am sorry for the late reply. Thanks for this contribution! |
|
No problem! More importantly, the tests failure looks like a flaky github actions behavior? It seems that the cluster creation in the step before timed out and thus there were no nodes to deploy the chart to. Can you try re-running the pipeline to verify that or should I do something else instead? |
|
I am so sorry @sebhoss for the lack fo responses, I am so busy these days...Yeah looks like a flaky job, I just re-triggered. |
|
Can we have this updated and added? |
|
Solved the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
helm templateusers to specify--namespace somethingwhile generating YAML files. See helm/helm#3553 for details and possible (other) workarounds.Note that without specifying
--namespacewhile callinghelm template,{{ .Release.Namespace }}defaults todefaultwhich might contradict what changed in #25.