feat: Make TypescriptConfig mutable, add TypescriptConfigPresets
#3535
+3,443
−356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3535 +/- ##
==========================================
+ Coverage 96.34% 96.37% +0.02%
==========================================
Files 192 193 +1
Lines 37696 38016 +320
Branches 3524 2676 -848
==========================================
+ Hits 36320 36637 +317
- Misses 1376 1379 +3 ☔ View full report in Codecov by Sentry. |
…mpilerOptionsMergeMethod` Added ability to control tsconfig merges right in `typescript-config.ts`, introducing the ability to alter the tsconfig intelligently and without escape hatches. Removed the tsconfig merging from `typescript.ts` and have it use the now-native merging ability, realinging the separation of concerns there. Adjusted tests to match the new functionality. Only one snapshot needed changed, all test pass.
…add other Presets
giseburt
force-pushed
the
3448-tsconfig-target-based
branch
from
22995b2
to
5418c52
Compare
2 tasks
giseburt
changed the title
typescript-config.ts, add TypeScriptSetCompilerOptionsMergeMethodTypescriptConfig mutable, add TypescriptConfigPresets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to control tsconfig merges right in
typescript-config.ts, introducing the ability to alter the tsconfig intelligently and without escape hatches.Removed the tsconfig merging from
typescript.tsand have it use the now-native merging ability, realinging the separation of concerns there.Adjusted tests to match the new functionality. Only one snapshot needed changed, all test pass.
Fixes #3448
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.