-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python)!: default license to Apache-2.0
if unset
#3395
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
+ Coverage 96.32% 96.34% +0.02%
==========================================
Files 191 192 +1
Lines 37407 37568 +161
Branches 3489 3509 +20
==========================================
+ Hits 36032 36195 +163
+ Misses 1375 1373 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really not have any tests for this? 😱
Also this looks like it will be a breaking change.
85ef6e1
to
7984e96
Compare
7984e96
to
2f72a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is going to be super weird. Because license
is defined here: https://github.com/projen/projen/blob/main/src/python/python-packaging.ts#L48
We need to add a @default
but then this also needs to change for all usages of PythonPackagingOptions
, not just poetry.
Apache-2.0
license to PythonProject
with Poetry or SetuptoolsApache-2.0
if unset
4dfe172
to
326ffbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Will holding this back to group with at least one other Breaking Change.
I'm also still wondering if we have a better transition path here. This feels high risk to unintentionally license a bunch of packages under Apache-2.0
@garysassano Been thinking more about this. We will at least have to add a warning about undefined license defaulting to Apache2.0. The warning can be removed with GA (make sure to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a warning for this.
Adding a default
Apache-2.0
license toPythonProject
to align it withNodeProject
.BREAKING CHANGE: The
PythonProject
now defaults to anApache-2.0
license. To use a different license, you must specify thelicense
property in your project configuration.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.