Fix examples running on LAN (#290)

- We should bind "0.0.0.0" for UdpSocket. - ` public_addresses` is not needed with `ServerAuthentication::Unsecure`.
projectharmonia · Jun 13, 2024 · b3f1505 · b3f1505
1 parent 434837b
commit b3f1505
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/bevy_replicon_renet/examples/simple_box.rs b/bevy_replicon_renet/examples/simple_box.rs
@@ -89,14 +89,13 @@ impl SimpleBoxPlugin {
  });
 
  let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
- let public_addr = SocketAddr::new(Ipv4Addr::LOCALHOST.into(), port);
- let socket = UdpSocket::bind(public_addr)?;
+ let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, port))?;
  let server_config = ServerConfig {
  current_time,
  max_clients: 10,
  protocol_id: PROTOCOL_ID,
  authentication: ServerAuthentication::Unsecure,
- public_addresses: vec![public_addr],
+ public_addresses: Default::default(),
  };
  let transport = NetcodeServerTransport::new(server_config, socket)?;
 
@@ -130,7 +129,7 @@ impl SimpleBoxPlugin {
  let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
  let client_id = current_time.as_millis() as u64;
  let server_addr = SocketAddr::new(ip, port);
- let socket = UdpSocket::bind((ip, 0))?;
+ let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
  let authentication = ClientAuthentication::Unsecure {
  client_id,
  protocol_id: PROTOCOL_ID,

diff --git a/bevy_replicon_renet/examples/tic_tac_toe.rs b/bevy_replicon_renet/examples/tic_tac_toe.rs
@@ -262,14 +262,13 @@ impl TicTacToePlugin {
  });
 
  let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
- let public_addr = SocketAddr::new(Ipv4Addr::LOCALHOST.into(), port);
- let socket = UdpSocket::bind(public_addr)?;
+ let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, port))?;
  let server_config = ServerConfig {
  current_time,
  max_clients: 1,
  protocol_id: PROTOCOL_ID,
  authentication: ServerAuthentication::Unsecure,
- public_addresses: vec![public_addr],
+ public_addresses: Default::default(),
  };
  let transport = NetcodeServerTransport::new(server_config, socket)?;
 
@@ -290,7 +289,7 @@ impl TicTacToePlugin {
  let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
  let client_id = current_time.as_millis() as u64;
  let server_addr = SocketAddr::new(ip, port);
- let socket = UdpSocket::bind((ip, 0))?;
+ let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
  let authentication = ClientAuthentication::Unsecure {
  client_id,
  protocol_id: PROTOCOL_ID,