update rubocop and rubocop-rspec #2837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
rubocop-7x
branch
2 times, most recently
from
d9d032e
to
5b571f4
Compare
jcoyne
force-pushed
the
rubocop-7x
branch
3 times, most recently
from
6cde58e
to
419f7c4
Compare
|
fyi — if you split out the changes to |
|
@thatbudakguy I would prefer if we can use git blame to see that these changes came from running rubocop when doing git blame. |
|
ok — I'm ambivalent, I guess, but it would be good to get somebody else's input before merging this |
sandbergja
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks, @jcoyne ! The .git-blame-ignore-revs feature seems interesting, but I don't think it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.