Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4993] Unleash - function to check "EC2 Individual VM Compute" feature flag. #5091

Merged
merged 12 commits into from
May 23, 2024

Conversation

bacciotti
Copy link
Contributor

@bacciotti bacciotti commented May 7, 2024

Jira Ticket

COST-4993

Description

This change will create a function that checks if cost-management.backend.feature-4403-enable-ec2-compute-processing is enabled.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-4993](https://issues.redhat.com/browse/COST-4993) "EC2 Individual VM Compute" feature flag

@bacciotti bacciotti added the aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (4b4c50a) to head (6beaa37).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5091     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        378     378             
  Lines      31622   31622             
  Branches    3756    3756             
=======================================
- Hits       29777   29776      -1     
  Misses      1177    1177             
- Partials     668     669      +1     

@bacciotti bacciotti marked this pull request as ready for review May 9, 2024 13:20
@bacciotti bacciotti requested review from a team as code owners May 9, 2024 13:20
djnakabaale
djnakabaale previously approved these changes May 22, 2024
@bacciotti bacciotti merged commit 6bae569 into main May 23, 2024
11 checks passed
@bacciotti bacciotti deleted the cost-4993_unleash_flag_ec2 branch May 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests smokes-required
Projects
None yet
2 participants