Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5015] Retrieve azure disk capacities #5089

Merged
merged 13 commits into from
May 17, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented May 6, 2024

Jira Ticket

COST-5015

Description

This change will create a table to house a mapping of product substrings related to Azure managed disks and their capacities in GiBs.

Testing

Hit masu endpoint, and check table:

DELETE 39
postgres=# select * from reporting_common_azurestoragecapacity;
 product_substring | capacity
-------------------+----------
 P1                |        4
 P2                |        8
 P3                |       16
 P4                |       32
 P6                |       64
 P10               |      128
 P15               |      256
 P20               |      512
 P30               |     1024
 P40               |     2048
 P50               |     4096
 P60               |     8192
 P70               |    16384
 P80               |    32767
 S4                |       32
 S6                |       64
 S10               |      128
 S15               |      256
 S20               |      512
 S30               |     1024
 S40               |     2048
 S50               |     4096
 S60               |     8192
 S70               |    16384
 S80               |    32767
 E1                |        4
 E2                |        8
 E3                |       16
 E4                |       32
 E6                |       64
 E10               |      128
 E15               |      256
 E20               |      512
 E30               |     1024
 E40               |     2048
 E50               |     4096
 E60               |     8192
 E70               |    16384
 E80               |    32767
(39 rows)

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.2%. Comparing base (febeb57) to head (6e12a8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5089   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        378     378           
  Lines      31583   31624   +41     
  Branches    3754    3756    +2     
=====================================
+ Hits       29738   29778   +40     
- Misses      1175    1177    +2     
+ Partials     670     669    -1     

@myersCody myersCody marked this pull request as ready for review May 9, 2024 13:59
@myersCody myersCody requested review from a team as code owners May 9, 2024 13:59
@myersCody myersCody added the skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. label May 9, 2024
@myersCody myersCody removed the skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. label May 9, 2024
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label May 16, 2024
@myersCody
Copy link
Contributor Author

/retest

maskarb
maskarb previously approved these changes May 16, 2024
@myersCody myersCody enabled auto-merge (squash) May 16, 2024 19:35
@myersCody myersCody added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels May 17, 2024
@myersCody
Copy link
Contributor Author

/retest

@cgoodfred
Copy link
Contributor

/retest

@myersCody myersCody merged commit 7bed556 into main May 17, 2024
11 checks passed
@myersCody myersCody deleted the COST-5015-azure-disk-capacities branch May 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
3 participants