Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4912] Calculate node based unattributed storage (Azure) #5066

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Apr 24, 2024

Jira Ticket

COST-3912

Description

This change will calculate the node based unattributed storage for Azure.

Testing

  1. Checkout Branch

  2. Create the test customer

  3. Load-test-customer-data
    Note:
    When I update the correlation logic to be partial matching, I added Azure Disk that I knew would not get correlated. That is the cost we are tracking here with this change.

  4. Check Ocp On azure.

postgres=# select sum(pretax_cost + markup_cost)  from org1234567.reporting_ocpazurecostlineitem_project_daily_summary_p where namespace='Storage unattributed';
     sum
-------------
 4.259804547
  1. Check OCP table to ensure back populate works:
postgres=# select sum(infrastructure_raw_cost) from reporting_ocpusagelineitem_daily_summary where namespace='Storage unattributed';
       sum
-------------------
4.259804547000000
(1 row)

Release Notes

  • proposed release note
* [COST-3912](https://issues.redhat.com/browse/COST-3912) Fix some things

@myersCody myersCody added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Apr 24, 2024
@myersCody
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (7f8cb20) to head (d6f5c5c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5066   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        375     375           
  Lines      31170   31170           
  Branches    3730    3730           
=====================================
+ Hits       29320   29323    +3     
+ Misses      1180    1179    -1     
+ Partials     670     668    -2     

@myersCody myersCody marked this pull request as ready for review April 25, 2024 18:11
@myersCody myersCody requested review from a team as code owners April 25, 2024 18:11
@myersCody myersCody marked this pull request as draft April 25, 2024 18:15
@myersCody myersCody marked this pull request as ready for review April 26, 2024 19:27
@myersCody myersCody marked this pull request as draft April 29, 2024 17:05
@myersCody myersCody marked this pull request as ready for review April 29, 2024 19:49
@myersCody myersCody marked this pull request as draft April 30, 2024 14:45
@myersCody myersCody removed the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants