[COST-4940] ros_report_shipper - Log report urls #5046
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@saltgen Why are we adding this log message to cost management instead of the ROS backend? |
|
@maskarb Additionally, should we log cleaned urls? |
|
What information do you need to log? I'm still not following the logic around adding this in cost management instead of ROS. Does the ROS backend not log the kafka message and contents that it processes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4940
Description
ROS is planning to create Kibana dashboard to display csv files that it may receive from Cost.
This simple change would make it easier to track such csvs.
Testing
Since this change is quite trivial I have not tested the same locally