[COST-4670] Enable copy-on-write in Pandas #4980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoran
added
the
smoke-tests
samdoran
changed the title
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
from
0e37e4e
to
9d08265
Compare
|
Right now this is likely a QE testing effort to evaluate the impact of any Memory improvements/degradations PRIOR to this being merged. Lets give QE time to test this and if they are satisfied they can be the ones to approve this PR for it to be merged. |
|
/retest |
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
from
9d08265
to
084baa2
Compare
esebesto
added
full-run-smoke-tests
|
/retest |
2 similar comments
|
/retest |
|
/retest |
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
2 times, most recently
from
f3d043d
to
f6e8a4d
Compare
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
from
f6e8a4d
to
517c6e7
Compare
|
/retest |
|
Tests are failing with Need to identify where we are doing chained assignments and update the code. |
Testing out the new behavior that will be the default in Pandas 3.0 https://pandas.pydata.org/docs/dev/whatsnew/v2.2.0.html#copy-on-write
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
from
517c6e7
to
bd1601a
Compare
samdoran
force-pushed
the
COST-4670/pandas-cow
branch
from
bd1601a
to
303126c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 377 377
Lines 31375 31375
Branches 3724 3724
=======================================
- Hits 29532 29529 -3
- Misses 1173 1176 +3
Partials 670 670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4670
Description
Enable copy-on-write in
pandas. This should result in better memory usage and more predictable performance.Testing
Notes
If this change has no negative impact, we should enable it now.