Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atempt to move ocp-gcp filter logic to trino #4398

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Atempt to move ocp-gcp filter logic to trino #4398

wants to merge 56 commits into from

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented May 26, 2023 •
edited

Jira Ticket

COST-3843

Description

This change will adds a little new logic to move ocp on gcp filter matching logic to trino

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Add OCP on GCP sources
  4. Validate everything runs correctly and cost is what we expect

Alt you can run QE test test_api_ocp_on_gcp_source_raw_calc

...

@codecov
Copy link

codecov bot commented May 26, 2023 •
edited

Codecov Report

Merging #4398 (a27edc7) into main (81e44c8) will decrease coverage by 0.0%.
The diff coverage is 87.3%.

@@           Coverage Diff           @@
##            main   #4398     +/-   ##
=======================================
- Coverage   93.8%   93.8%   -0.0%     
=======================================
  Files        367     367             
  Lines      30256   30315     +59     
  Branches    3580    3590     +10     
=======================================
+ Hits       28376   28428     +52     
- Misses      1220    1222      +2     
- Partials     660     665      +5

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label May 31, 2023
@lcouzens lcouzens marked this pull request as ready for review May 31, 2023 15:01
@lcouzens lcouzens requested review from a team as code owners May 31, 2023 15:01
@lcouzens lcouzens marked this pull request as draft May 31, 2023 16:03
cgoodfred
cgoodfred previously approved these changes Jun 7, 2023
View reviewed changes
@lcouzens lcouzens removed the smoke-tests pr_check will build the image and run minimal required smokes label Jun 9, 2023
cgoodfred
cgoodfred previously approved these changes Jun 9, 2023
View reviewed changes
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 3, 2023
cgoodfred
cgoodfred previously approved these changes Jul 3, 2023
View reviewed changes
@lcouzens lcouzens removed the smoke-tests pr_check will build the image and run minimal required smokes label Aug 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskarb maskarb maskarb left review comments

@djnakabaale djnakabaale djnakabaale left review comments

@cgoodfred cgoodfred cgoodfred left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
smokes-required
Projects
None yet
Milestone
No milestone
5 participants
@lcouzens @djnakabaale @maskarb @cgoodfred @adberglund