This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
chore update go gitlab #982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remove variable API didn't have option to set the enviorment scope, so there was an workaround by hooking into the request retry option, and setting the scope option by hand there. This was fixed in the latest release of go-gitlab and now this can be done simply by passing in a option object.
The upload command now takes a io.Reader and a file name. This is why we need to pass it by hand now
This has been a change around the whole go-gitlab API
These variables are not their own specific types
|
hey, I've been wanting to ask this for a while, but what is the best way to set the local environment for running the tests properly? |
|
This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates go-gitlab library to the newest version so we can add more then
one file to snippets.
The problem here is that there is one huge nasty change that changes a lot of slices to be pointers to slices see here
There are also some good things as, no need to use the workaround for setting
the scope for environment filters when removing project variables.
There is also a change in the way how labels are treated in most places (this
actually just looks like a normalization around the library since some places
already used this custom type and some didn't).
There is quite a lot of pointer derefrencing now, and I have not done any real
testing so there might be some problems so this probably should be tested better
before merging.
Each change should be in it's own commit for easier review, but should be
squashed before merge, because most of the commits fail to build and I don't
like having commits with build failures.
Commit messages should have better explanation for most changes.
Related Issue
Resolves #872
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes