Make tox -e pylint run all commands, even when failing #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
added
the
testing and CI
|
@marvinpfoertner we can also wait for the outcome of your tests on individual pylint configs for the individual modules before merging this. |
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 57 57
Lines 3040 3040
Branches 391 391
=======================================
Hits 2229 2229
Misses 660 660
Partials 151 151 Continue to review full report at Codecov.
|
marvinpfoertner
approved these changes
Aug 25, 2020
You can go ahead and merge this, individual pylint configs sadly don't meet our requirements. See also pylint-dev/pylint#618. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
tox -e pylintstops after encountering the first error. It would however be more informative to get the full linting report, to be able to work on all encountered issues. This PR fixes that.