Java Server #16
Open
Java Server #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyankark
requested changes
Jun 10, 2021
There was a problem hiding this comment.
Many thanks for the PR Ayan! Can you create a new folder called Java and shift your code inside that. Also, see if you can only commit the server code and not the Android app. Also, it will be great if you also add a README for future users to be able to run your code!! (You can also modify our README by adding a section called Java like we have for Python and Node)
| @@ -28,7 +28,7 @@ public void onOpen(WebSocket conn, ClientHandshake handshake) { | |||
|
|
|||
| @Override | |||
| public void onClose(WebSocket conn, int code, String reason, boolean remote) { | |||
|
|
|||
| mSocket.close(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we just keep this file and remove everything else that may be unnecessary? I believe this is the server core? May I suggest that you clean the code here a bit. Take care of indentations etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,I am ayan .This is a java server built app for android devices to recieve stream from phonePi app